salvage points shop #2510
salvage points shop #2510
Conversation
github-actions
bot
added
size/L
|
Cannot wait to see this active in game. Though possibly here's a few suggestions for extra bits to stick in there
|
|
tg has survival pens which ill port later (epipen does next to nothing if you arent crit), but ill add funny suits too |
|
Direction review 24 hours |
|
Okie dokie, we'd like to do a test merge on this (and the voucher PR), but can we wait until after the 26th? There's gonna be events and direction will be a little low on manpower, so it would be tough to monitor. |
|
sure |
| using Robust.Client.UserInterface.Controls; | ||
| using Robust.Client.UserInterface.XAML; |
| VendingContents.SearchBar = SearchBar; | ||
| VendingContents.DataFilterCondition += DataFilterCondition; | ||
| VendingContents.GenerateItem += GenerateButton; | ||
| VendingContents.ItemKeyBindDown += (args, data) => OnItemSelected?.Invoke(((ShopVendorListingData) data).Index); |
| UpdateBalance(_vendor.GetBalance(_owner, user)); | ||
| } | ||
|
|
||
| private bool DataFilterCondition(string filter, ListData data) |
There was a problem hiding this comment.
is there a reason why this cant be static
| [DataField(customTypeSerializer: typeof(TimeOffsetSerializer))] | ||
| public TimeSpan NextDeny; | ||
|
|
||
| [DataField(customTypeSerializer: typeof(TimeOffsetSerializer))] | ||
| public TimeSpan NextEject; |
| /// Another component must handle <see cref="ShopVendorBalanceEvent"/> and <see cref="ShopVendorPurchaseEvent"/> to work. | ||
| /// </summary> | ||
| [RegisterComponent, NetworkedComponent, Access(typeof(SharedShopVendorSystem))] | ||
| [AutoGenerateComponentState, AutoGenerateComponentPause] |
There was a problem hiding this comment.
>adds the AutoGenerateComponentPause attribute
>doesnt mark any fields as AutoPaused
|
Thanks for the patience, feel free to go ahead and merge this if it's ready. We'll keep a close eye on it in game and see how people feel |
|
the draft is coming |
About the PR
reworked the salvage vendor to be a shop that gives you items in exchange for mining points
2 new things added for it:
moved old gear like pka and pickaxe into the lockers so you don't have to buy them
also gave salv mesons roundstart, they had welders but no eye protection very nice
more stuff like shelter capsules later
Why / Balance
everything in it is tg parity with the following additions:
reward people for mining and they will probably mine harder
Technical details
because VendingMachine is god component a bunch of stuff had to be duplicated which is great
Media
get in were going to lavaland
too poor to get crusher its over
Requirements
Breaking changes
removed and migrated away salvage vendor restocks, since it is no longer a vending machine
Changelog
🆑